Remove extern(Pascal), deprecated in v2.084.0 #11989
Conversation
Geod24
requested review from
ibuclaw,
kinke,
MartinNowak,
RazvanN7,
UplinkCoder and
WalterBright
as code owners
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11989" |
|
dlang.org was already cleaned up when I did the deprecation, there's only the code in druntime left: dlang/druntime#3285 |
Geod24
force-pushed
the
remove-extern-pascal
branch
from
d753bf3 to
31e5a5f
Compare
|
I changed one of the unit tests. Previously it was simply adapted to use user-provided deprecation, however it's a parser test, not a semantic test, so deprecations won't get triggered. Any deprecation in the parser is likely to be temporary, so it would just be pushing the problem to the next contributor for dubious reasons, hence why I just removed it. |
Geod24
force-pushed
the
remove-extern-pascal
branch
from
31e5a5f to
b271673
Compare
| pascal = 5u, | ||
| objc = 6u, | ||
| system = 7u, | ||
| objc = 5u, |
There was a problem hiding this comment.
@Geod24 Oops, just realised that you broke downstream gdc and ldc.
There was a problem hiding this comment.
Isn't it expected tho ?
You didn't update global.h
There was a problem hiding this comment.
Ergh, an oversight, will fix.
This was overlooked in dlang#11989
This was overlooked in dlang#11989
This was overlooked in #11989
It's been 10 releases, time to go! I could make it an explicit error but I don't think that makes much sense.
Will raise dlang.org PR.