Implementation of Properties. by 12345swordy · Pull Request #12097 · dlang/dmd

12345swordy · 2021-01-04T14:12:34Z

I have rebase @JinShil PR on this and added some to the test.

TODO:

disallow functions that is mark property from returning ref.
Implement binary operators successfully.
Implement unary operators successfully.
Disallow parameters for property functions
write a dip on this for justification on modifying properties.

cc @thewilsonator need a "need DIP" and "Spec PR" red tag for this.

PetarKirov · 2021-01-04T17:12:21Z

After a few years of experience with other languages I've come to appreciate the dedicated syntax that some of them provide (e.g. C#, Dart, JavaScript), as opposed to D's bare-bones approach.
That said, think we can have a two step process:

Define the semantics using existing function syntax + @property
Add syntax sugar on top. The expression-bodied members syntax would be a very nice win.

This could be done via a single, or two separate DIPs.

adamdruppe · 2021-01-04T17:27:36Z

On Mon, Jan 04, 2021 at 09:12:37AM -0800, Petar Kirov wrote: 2. Add syntax sugar on top. The expression-bodied members syntax would be a very nice win.

please note: #11833 if you wanna help by writing the spec PR that'd probably help keep that after the preview.

ibuclaw · 2021-01-04T19:30:49Z

src/dmd/expressionsem.d

+*      the rewritten expression if the procedure succeeds, an `ErrorExp` if the
+*      and error is encountered, or `null` if `e.e1` is not a `@property` function.
+*/
+Expression SemanticProp(BinAssignExp e, Scope* sc)


Isn't this called binSemanticProp?

It used to be called that. It was initially to be implemented for binary operators only, which I plan to expand father than that. That may change in future.

test/runnable/test8006.d

tgehr · 2021-01-05T00:17:08Z

Nice, but why those?

disallow functions that is mark property from returning ref.
Disallow parameters for property functions

12345swordy · 2021-01-05T00:45:37Z

Nice, but why those?

disallow functions that is mark property from returning ref.
Disallow parameters for property functions

That is part of the design I have in mind. It meant to be used as a variable, with the key difference is that you can't obtain the address of it directly nor can you pass it to a ref parameter of a function. All write and read access of the private variable outside the module must go through the functions themselves. No exceptions.

I will explain this further in detail when I write up the dip of this.

Edit: This is my major influence. https://docs.microsoft.com/en-us/dotnet/csharp/programming-guide/classes-and-structs/properties

RazvanN7 · 2021-01-06T08:23:42Z

@12345swordy Can you please link the original PR so that reviewers can easily keep track of the discussions?

12345swordy · 2021-01-06T14:54:00Z

@12345swordy Can you please link the original PR so that reviewers can easily keep track of the discussions?

#7079

12345swordy · 2021-01-08T23:14:18Z

~~Erm, it appears I didn't re base correctly.... Any tips?~~

NM

12345swordy · 2021-01-30T04:12:05Z

OK, after much discussion on discord, I decided to remove the "disallow functions that is mark property from returning ref" restriction.

12345swordy · 2021-05-17T20:05:52Z

Finished 80% implementation of binary operators for properties, the other 20% involves an edge case that I am not sure that it should compile.
Going to start working on unary operators now.

dlang-bot · 2021-05-31T19:46:56Z

Thanks for your pull request and interest in making D better, @12345swordy! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
I have provided a detailed rationale explaining my changes
New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	21658	normal	Debugger is reading enums with EnumBaseType incorrectly

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12097"

12345swordy · 2021-07-23T19:50:50Z

@RazvanN7 are you available at slacks or at discord? I need assistance on finishing this.

12345swordy · 2021-07-26T22:37:31Z

It is done for review. Need to rebase it, now.

…in the case where 't +=4' where T is the type itself that has alias this a property function.

…ncorrectly." This reverts commit 1e8514e.

ljmf00 · 2021-08-04T00:26:48Z

test/fail_compilation/test8006.d

+    testTInt();
+    testTString();
+    testFreeFunctions();
+}


Add a newline to conform with POSIX 3.206 .

ljmf00 · 2021-08-04T00:26:57Z

test/runnable/test8006.d

+    testSideEffectsInt();
+
+    testSideEffectsString();
+}


RazvanN7 · 2021-10-19T07:04:33Z

@12345swordy Sorry for the late reply. Yes, I am available on slack. Whatever questions you may have, feel free to ask.

PetarKirov added Review:Needs Changelog A changelog entry needs to be added to /changelog Review:Needs Spec PR A PR updating the language specification needs to be submitted to dlang.org Review:Pending DIP Approval labels Jan 4, 2021

ibuclaw requested changes Jan 4, 2021

View reviewed changes

tgehr reviewed Jan 5, 2021

View reviewed changes

test/runnable/test8006.d Outdated Show resolved Hide resolved

dlang-bot added the Severity:Bug Fix label May 31, 2021

dlang-bot added the Review:Needs Work label Jul 4, 2021

dlang-bot added Review:Needs Work and removed Review:Needs Work labels Jul 11, 2021

dlang-bot removed the Review:Needs Work label Jul 26, 2021

12345swordy added 8 commits July 26, 2021 17:43

Fix issue 21658 Debugger is reading enums with EnumBaseType incorrectly.

cec84c7

Initial Commit

9f9a466

Replace tabs with spaces

de53f63

Implement the majority of the binary operators for properties except …

ba98b5d

…in the case where 't +=4' where T is the type itself that has alias this a property function.

Refactor implementation of property into its own file.

4467e37

Revert "Fix issue 21658 Debugger is reading enums with EnumBaseType i…

4543205

…ncorrectly." This reverts commit 1e8514e.

Implement prepost expression for properties

d479a1c

Finished the implementation of unary properties.

80a159f

12345swordy added 2 commits July 26, 2021 17:43

Editing out the printfs

06a799d

rebased

239bb1b

dlang-bot added the Review:Needs Work label Jul 27, 2021

Comment out printf

3b20d18

dlang-bot removed the Review:Needs Work label Aug 4, 2021

ljmf00 reviewed Aug 4, 2021

View reviewed changes

dlang-bot added the Review:Needs Work label Aug 4, 2021

implement post and pre-post increments and decrements

4995dd4

dlang-bot removed the Review:Needs Work label Oct 19, 2021

comment out printf

7d79b9c

dlang-bot added the Review:Needs Work label Oct 19, 2021

dlang-bot added the Review:stalled label Jan 17, 2022

12345swordy mentioned this pull request Mar 30, 2022

Audit Log File #12710

Closed

dlang-bot added the Review:Needs Rebase label Apr 7, 2022

12345swordy closed this Jun 23, 2022

Uh oh!

Conversation

12345swordy commented Jan 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

PetarKirov commented Jan 4, 2021

Uh oh!

adamdruppe commented Jan 4, 2021 via email

Uh oh!

ibuclaw Jan 4, 2021

Choose a reason for hiding this comment

Uh oh!

12345swordy Jan 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tgehr commented Jan 5, 2021

Uh oh!

12345swordy commented Jan 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

RazvanN7 commented Jan 6, 2021

Uh oh!

12345swordy commented Jan 6, 2021

Uh oh!

12345swordy commented Jan 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

12345swordy commented Jan 30, 2021

Uh oh!

12345swordy commented May 17, 2021

Uh oh!

dlang-bot commented May 31, 2021

Bugzilla references

Testing this PR locally

Uh oh!

12345swordy commented Jul 23, 2021

Uh oh!

12345swordy commented Jul 26, 2021

Uh oh!

ljmf00 Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

ljmf00 Aug 4, 2021

Choose a reason for hiding this comment

Uh oh!

RazvanN7 commented Oct 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

12345swordy commented Jan 4, 2021 •

edited

Loading

12345swordy commented Jan 5, 2021 •

edited

Loading

12345swordy commented Jan 8, 2021 •

edited

Loading