Skip to content

changelog/deprecate_dualcontext: Reword to neutral tone #12111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibuclaw merged 1 commit into from
Jan 11, 2021
Merged

changelog/deprecate_dualcontext: Reword to neutral tone #12111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions changelog/deprecate_dualcontext.dd
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,9 @@
Deprecate local templates that receive local symbols by alias

Support for local and member templates which can be instantiated with local
symbols was added to the language in D 2.087.0, however there are a number of
issues with the feature including:
Support for instantiating local and member templates with local
symbols was implemented in DMD 2.087.0. However, the implementation
was incompatible with GDC and LDC backends.

- Only DMD has code-gen support for the feature.
- There has been no support to implement this feature in either GDC or LDC.
- There is still no language specification that describes the feature.

Because of this, there has been a dead feature introduced to the language for
over nine releases, so now it has been deprecated, and due to be fully reverted
in a future release.
In order to maintain feature parity among D implementations, this
improvement has been deprecated, and may be removed from a future DMD
Copy link
Member Author

@CyberShadow CyberShadow Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that the removal is conditional on that the compiler vendors fail to implement the feature in their backends.

Copy link
Contributor

@12345swordy 12345swordy Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't being hostile at all. You are reading between lines here.

Copy link
Contributor

@RazvanN7 RazvanN7 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of phrases like "dead feature" and "over nine releases" have a negative tone and the rephrasing is much more appropriate to the professional, neutral tone of an official document.

Copy link
Contributor

@12345swordy 12345swordy Jan 8, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of phrases like "dead feature" and "over nine releases" have a negative tone

The negative note that is the result of your interpretation here. Not everyone have the same interpretation here.

Copy link
Contributor

@dnadlinger dnadlinger Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the context being a professional software project changelog, it does clearly read aggravated/frustrated to me. We do not want to convey that sentiment to users.

Copy link
Contributor

@12345swordy 12345swordy Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"may be removed from a future DMD"
May!? What do you mean by may? It quite clear that @ibuclaw intended to remove this in the feature. Don't give them any false hopes here.

Copy link
Contributor

@RazvanN7 RazvanN7 Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibuclaw has proposed alternative fixes. Although there is a small chance that anyone is going to actually implement those, I think it is better to stay positive.

Copy link
Contributor

@12345swordy 12345swordy Jan 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ibuclaw has proposed alternative fixes.
Although there is a small chance that anyone is going to actually implement those, I think it is better to stay positive.

Just because you proposed something doesn't mean it going to happen. Let not give them false hope here.

release.