Fix 21569: Set RES path relative to build.d's directory#12143
Merged
dlang-bot merged 1 commit intodlang:stablefrom Jan 21, 2021
Merged
Fix 21569: Set RES path relative to build.d's directory#12143dlang-bot merged 1 commit intodlang:stablefrom
dlang-bot merged 1 commit intodlang:stablefrom
Conversation
This ensures the resulting path is correct even for the sources distributed alongside the official releases. This is a regression introduced by dlang#11269.
Contributor
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#12143" |
PetarKirov
approved these changes
Jan 21, 2021
Member
For future reference: The contents of e.g. http://downloads.dlang.org/releases/2.x/2.095.0/dmd.2.095.0.linux.tar.xz look like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures the resulting path is correct even for the sources distributed alongside the official releases.
The issues is a regression introduced by #11269.