-
-
Notifications
You must be signed in to change notification settings - Fork 667
Print warning if not using either preview or revert DIP1000 switches #12159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request and interest in making D better, @atilaneves! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12159" |
|
I'd be much more comfortable with pushing for this switch if we made sure most libraries in Buildkite compiled with it. |
| "Please use -revert=dip1000 to maintain current behavior."); | ||
| deprecationSupplemental( | ||
| Loc.initial, | ||
| "https://github.com/dlang/DIPs/blob/master/DIPs/other/DIP1000.md"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahem, this DIP is superseeded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. I guess the link should be this then?
|
Sorry to hijack this PR but this will create yet another flag that requires two |
|
Wouldn't a much better solution to only show deprecations if there's code that would be broken with the new default? |
I hadn't considered that. Let me take a look at the code and see how to get it done. Thanks for the suggestion! |
|
Closing this in favor of #12578 |
If we transition to enabling DIP1000 by default (which we want to do), users will have to add
-preview=dip1000to maintain the current behaviour, with possible code breakage for those who don't. This might be a problem in dependencies.To gently nudge the transition, this PR prints out a deprecation warning so that users are encouraged to user either preview or revert switches explicitly. After a grace period we can deprecate
-preview=dip1000.Nothing changes for now except for the annoying message.