Skip to content

fix Issue 21833 - Optimizer incorrectly rewrites integer comparison t…#12444

Merged
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:fix21833
Apr 19, 2021
Merged

fix Issue 21833 - Optimizer incorrectly rewrites integer comparison t…#12444
dlang-bot merged 1 commit intodlang:masterfrom
WalterBright:fix21833

Conversation

@WalterBright
Copy link
Member

…o unsigned short comparison

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
21833 normal Optimizer incorrectly rewrites integer comparison to unsigned short comparison

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#12444"

@WalterBright WalterBright added the Review:WIP Work In Progress - not ready for review or pulling label Apr 16, 2021
@WalterBright
Copy link
Member Author

Hmm, this is the wrong fix. Will work on it tomorrow.

@WalterBright WalterBright removed the Review:WIP Work In Progress - not ready for review or pulling label Apr 17, 2021
@WalterBright
Copy link
Member Author

The test suite errors are a new crop of unrelated heisenbugs.

@MoonlightSentinel
Copy link
Contributor

Rebase to current master and those will vanish
(We had to replace the old CodeCov token because of an error on their side...)

@dlang-bot dlang-bot merged commit e497884 into dlang:master Apr 19, 2021
@WalterBright WalterBright deleted the fix21833 branch April 19, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments