dmd.target: Change size field types from uint to ubyte#12535
Merged
thewilsonator merged 2 commits intodlang:masterfrom May 19, 2021
Merged
dmd.target: Change size field types from uint to ubyte#12535thewilsonator merged 2 commits intodlang:masterfrom
uint to ubyte#12535thewilsonator merged 2 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12535" |
thewilsonator
approved these changes
May 19, 2021
Contributor
|
seems that #12454 was not enough |
Member
Author
Hmm, ping @WalterBright then. Do we know how memory hungry the program is? Or does it just trigger timeout on dmd. |
Contributor
|
Not sure, I think the assert was tripped, not OOM so maybe that was just a random failure? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type size fields are unlikely to be any value greater than
32. The ClassInfo size has been fixed at152for decades.