Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#12980" |
WalterBright
force-pushed
the
FieldState
branch
4 times, most recently
from
f49cfdd to
dbbe036
Compare
ibuclaw
previously requested changes
Aug 16, 2021
Member
ibuclaw
left a comment
ibuclaw
left a comment
There was a problem hiding this comment.
Headers aren't quite right, but rest looks fine.
src/dmd/attrib.h
Outdated
| const char *kind() const; | ||
| bool oneMember(Dsymbol **ps, Identifier *ident); | ||
| void setFieldOffset(AggregateDeclaration *ad, unsigned *poffset, bool isunion); | ||
| void setFieldOffset(AggregateDeclaration *ad, FieldState *fieldState, bool isunion); |
WalterBright
force-pushed
the
FieldState
branch
from
dbbe036 to
4193e5a
Compare
RazvanN7
approved these changes
Aug 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring is because state needed to be carried around for bit fields is more than what is needed for regular fields. So replace the
offsetparameter withfieldState. The bit field PR will just add more toFieldState.Doing it as a separate refactoring to practice what I preach :-)