Skip to content

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Mar 25, 2022

The fallback on looking at the line and column number was added when sequenceNumber was set in the constructor of a VarDeclaration, but since #13530 it's set in VarDeclaration.semantic. Looking at the line number is unreliable because it can be set with #line directives, so this should be simpler and more robust.

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label Mar 25, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#13889"

@dkorpel dkorpel marked this pull request as ready for review March 25, 2022 16:48
@thewilsonator
Copy link
Contributor

Needs a rebase to clear CI errors

@dkorpel dkorpel force-pushed the encloses-lifetime-simplify branch from 29f1ac2 to 4b18241 Compare March 27, 2022 17:04
@dkorpel dkorpel merged commit 8ad1c74 into dlang:master Mar 27, 2022
@dkorpel dkorpel deleted the encloses-lifetime-simplify branch March 27, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dip1000 memory safety with scope, ref, return Merge:auto-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants