ImportC: add __check(assign-expression) extension#14026
ImportC: add __check(assign-expression) extension#14026RazvanN7 merged 1 commit intodlang:masterfrom
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14026" |
2ccdcdf to
de5ac77
Compare
|
the name __assert is already used for the assert failure function on some platforms (see druntime core.stdc.assert for a list) if it's made a keyword, the assert header and uses of the macro will fail to parse |
|
Curses! Any ideas for a replacement keyword for |
|
How about |
|
Changed |
89e2df8 to
3c45c88
Compare
I already dumped my thoughts on using known keywords for reserved identifiers in C when |
src/dmd/cparse.d
Outdated
| e = cparseGenericSelection(); | ||
| break; | ||
|
|
||
| case TOK._assert: // __assert(assign-exp) extension |
There was a problem hiding this comment.
This should be renamed to __check as well
|
ping @WalterBright |
|
I want to make a new suggestion to you; if the English meaning is not contradictory! "ascertain" that can't introduce new conflicts never? Sounds good, huh? Okay, it's 3 letters more but it is better than underscore typed by double key press.:) SDB@79 |
|
@WalterBright what is the status of this PR? |
|
@WalterBright is this good to go? |
ibuclaw
left a comment
There was a problem hiding this comment.
Looked at the documentation, looked at the first source file. Definitely not ready to go.
b7d0c24 to
8ab3663
Compare
8ab3663 to
043d2aa
Compare
043d2aa to
81c15a9
Compare
|
Ready to merge |
|
@WalterBright @RazvanN7 How do we know this works? The test is never ran by the testsuite! |
Trying to use
assertin ImportC without the preprocessor gets tiresome, so I added __assert as an extension.