Skip to content

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented May 6, 2022

Disable deprecation warnings introduced by #12578. Doesn't completely remove the supporting code, so re-enabling should be easy.

The release for 2.100 came faster than expected, and lots of things aren't ready yet: Documentation is still being written, better safety error messages (#13957) haven't landed, many deprecation warnings for would-be dip1000 errors are missing, and deprecation warnings it does give may be false positives since inference of scope / return is currently broken without -preview=dip1000.

@WalterBright @atilaneves I propose to move this change to 2.101, because I'm afraid rushing the transition is only giving confusion to users.

@dkorpel dkorpel added the dip1000 memory safety with scope, ref, return label May 6, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14085"

@dlang-bot dlang-bot merged commit 159dd03 into dlang:stable May 7, 2022
@dkorpel dkorpel deleted the revert-dip1000 branch May 9, 2022 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dip1000 memory safety with scope, ref, return Merge:auto-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants