Skip to content

Fix autotester whitespace failure#14154

Merged
RazvanN7 merged 1 commit intodlang:masterfrom
RazvanN7:fix_autotester
May 24, 2022
Merged

Fix autotester whitespace failure#14154
RazvanN7 merged 1 commit intodlang:masterfrom
RazvanN7:fix_autotester

Conversation

@RazvanN7
Copy link
Contributor

Replaced tabs with whitespaces.

@RazvanN7 RazvanN7 added Review:Trivial typos, formatting, comments Review:Blocking Other Work review and pulling should be a priority labels May 24, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14154"

@thewilsonator
Copy link
Contributor

Thanks!

@WalterBright
Copy link
Member

Why didn't the checkwhitespace program say which file it was?

@RazvanN7
Copy link
Contributor Author

It's probably a bug in the autotester stdin/stderr redirect. Running the command locally gives all the information, including the file and line.

thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request May 26, 2022
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Blocking Other Work review and pulling should be a priority Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants