Skip to content

Fix -v output of test3004#14268

Merged
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:fix-test-3004
Jul 4, 2022
Merged

Fix -v output of test3004#14268
dlang-bot merged 1 commit intodlang:masterfrom
dkorpel:fix-test-3004

Conversation

@dkorpel
Copy link
Contributor

@dkorpel dkorpel commented Jul 4, 2022

Blocks dlang/druntime#3866, which adds an import to core.internal.array.duplication to the -v output.
The now removed core.internal.array.appending line was added in #13495 and not relevant to the test either.

@dkorpel dkorpel added the Review:Blocking Other Work review and pulling should be a priority label Jul 4, 2022
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @dkorpel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14268"

@dlang-bot dlang-bot merged commit e7a77de into dlang:master Jul 4, 2022
@dkorpel dkorpel deleted the fix-test-3004 branch July 4, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Blocking Other Work review and pulling should be a priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants