Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 19268 - BetterC turns off .dup for CTFE #14819

Merged
merged 1 commit into from
Jan 15, 2023
Merged

fix Issue 19268 - BetterC turns off .dup for CTFE #14819

merged 1 commit into from
Jan 15, 2023

Conversation

WalterBright
Copy link
Member

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Jan 15, 2023 •
edited
Loading

Thanks for your pull request, @WalterBright!

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 19268 regression BetterC turns off .dup for CTFE

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#14819"

dkorpel
dkorpel reviewed Jan 15, 2023
View reviewed changes
Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as a stop gap solution, but ideally functions do not have to version out code to accommodate them being used at CTFE in betterC.

@WalterBright WalterBright force-pushed the fix19268 branch 2 times, most recently from 21e15b4 to 0133949 Compare January 15, 2023 19:56
@dkorpel dkorpel changed the base branch from master to stable January 15, 2023 22:07
@dkorpel dkorpel requested a review from ibuclaw as a code owner January 15, 2023 22:07
@dkorpel dkorpel force-pushed the fix19268 branch 2 times, most recently from 4015390 to 3a90f62 Compare January 15, 2023 22:11
@dlang-bot dlang-bot merged commit d181988 into dlang:stable Jan 15, 2023
@WalterBright WalterBright deleted the fix19268 branch January 16, 2023 05:10
@dkorpel dkorpel mentioned this pull request Feb 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkorpel dkorpel dkorpel approved these changes

@ibuclaw ibuclaw Awaiting requested review from ibuclaw

Assignees
No one assigned
Labels
Merge:auto-merge Severity:Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalterBright @dlang-bot @dkorpel