-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Drop Phobos dependency for compiler tests #16587
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#16587" |
212a600
to
6bda4c1
Compare
Currently just useful to get a CI-generated list of problematic tests that would need to be adapted (incl. handling the
The |
It's not just the pow operator, but So maybe |
737e2e6
to
48d9332
Compare
48d9332
to
8318103
Compare
I looked at the power function in std.math, it's a pretty involved affair to move that out, if I remember right it needs exp. It's not just std.math that has to be moved either, it's multiple modules. It doesn't work in -betterC because not all of it is templated, it's horribly coupled to having a binary. |
The entire
Please keep the discussion on this topic, that's entirely unrelated. FWIW, I've always been against dummy-templatizing druntime/Phobos functions just for the sake of providing symbols for the crappy |
Actually I've been thinking about this very issue, we already link in per binary an object file, why not include some other stuff with it with GC'able sections? Note: I mentioned -betterC as that is how I found it. Great way to find issues such as this. |
The goal here is to render
make dmd-test
totally independent from Phobos, only depending on druntime in the same repo here.