Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually give deprecation for -noboundscheck #16687

Merged
merged 2 commits into from
Jul 13, 2024

Conversation

thewilsonator
Copy link
Contributor

This has been deprecated for at least 7 years...

Not sure what the comment policy is for such a long deprecated switch, see e.g.:

// @@@DEPRECATED_2.111@@@
// Deprecated in 2.101, remove in 2.111
eSink.deprecation(Loc.initial, "`-debug=number` is deprecated, use debug identifiers instead");

for the -debug=number feature deprecation.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16687"

@schveiguy
Copy link
Member

Put in a comment for the target version for removal, like the other thing you quoted.

@thewilsonator
Copy link
Contributor Author

Yeah, but how many versions into the future? It's been deprecated for ages but no deprecation warning was given. I assume we don't want to wait the full 10(?) releases.

This has been deprecated for at least 7 years...
@thewilsonator
Copy link
Contributor Author

Done, I chose 3 releases arbitrarily. If someone wants to complain they can change it later.

compiler/src/dmd/mars.d Outdated Show resolved Hide resolved
Co-authored-by: Jeremy Baxter <jeremy@baxters.nz>
@thewilsonator thewilsonator merged commit 9a5ce0e into dlang:master Jul 13, 2024
40 of 41 checks passed
@thewilsonator thewilsonator deleted the noboundscheck branch July 13, 2024 08:08
@Geod24
Copy link
Member

Geod24 commented Jul 13, 2024

@thewilsonator : If it doesn't warn on usage, it's not deprecated. We should follow the 10 releases policy there.

thewilsonator added a commit to thewilsonator/dmd that referenced this pull request Oct 7, 2024
This has been deprecated for at least 7 years...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants