Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ddoc] Show TypeCtor method attributes after parameters #16708

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 15, 2024

This is more readable and avoids confusion when there's a non-void return type.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16708"

@ntrel
Copy link
Contributor Author

ntrel commented Jul 15, 2024

buildkite failing due to ldc config issue:

CMake Error at cmake/Modules/FindLLVM.cmake:62 (message):
  Unsupported LLVM version 14.0.0 found (/bin/llvm-config).  At least version
  15.0 is required.  You can also set variables 'LLVM_ROOT_DIR' or
  'LLVM_CONFIG' to use a different LLVM installation.
Call Stack (most recent call first):
  cmake/Modules/FindLLVM.cmake:190 (_LLVM_FAIL)
  CMakeLists.txt:37 (find_package)

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change, the immutable int f() {} syntax is easily confused with immutable(int) f() {}. Is there a reason to limit this to ddoc? Lots of error messages to update?

@RazvanN7 RazvanN7 merged commit 6b5e8f6 into dlang:master Jul 16, 2024
40 of 41 checks passed
@ntrel ntrel deleted the post-qual branch July 18, 2024 19:26
@ntrel
Copy link
Contributor Author

ntrel commented Jul 19, 2024

I just thought the di change might be more disruptive, but yes it would be good. I might do that soon.

ntrel added a commit to ntrel/dmd that referenced this pull request Jul 19, 2024
ntrel added a commit to ntrel/dmd that referenced this pull request Jul 19, 2024
dkorpel pushed a commit that referenced this pull request Jul 20, 2024
…6732)

* [.di generation] Show TypeCtor method attributes after parameters

Follow up to #16708.

* Add changelog
kinke pushed a commit to ldc-developers/ldc that referenced this pull request Jul 31, 2024
…ang/dmd!16732)

* [.di generation] Show TypeCtor method attributes after parameters

Follow up to dlang/dmd#16708.

* Add changelog
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request Oct 7, 2024
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request Oct 7, 2024
…ang#16732)

* [.di generation] Show TypeCtor method attributes after parameters

Follow up to dlang#16708.

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants