Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify static assert #16764

Merged
merged 2 commits into from
Aug 5, 2024
Merged

simplify static assert #16764

merged 2 commits into from
Aug 5, 2024

Conversation

0-v-0
Copy link
Contributor

@0-v-0 0-v-0 commented Aug 2, 2024

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @0-v-0! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16764"

pragma(msg, "Error: Expected TOK.", enumName, " to be ", idx, " but is ", __traits(getMember, TOK, enumName));
static assert(0);
}
static foreach (idx, enumName; __traits(allMembers, TOK)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static foreach is not available yet in the bootstrap compiler unfortunately

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe it's the multi-arguments static assert message causing the error

@0-v-0
Copy link
Contributor Author

0-v-0 commented Aug 2, 2024

What other features cannot be used in the bootstrap compiler?

@dkorpel
Copy link
Contributor

dkorpel commented Aug 2, 2024

Currently the bootstrap compiler is dmd 2.076, so anything introduced after that is off the table:

https://dlang.org/changelog/2.076.0.html

@dkorpel dkorpel merged commit b02f718 into dlang:master Aug 5, 2024
41 checks passed
thewilsonator pushed a commit to thewilsonator/dmd that referenced this pull request Oct 7, 2024
* simplify static assert

* fix error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants