Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase stable4 #16965

Closed
wants to merge 15 commits into from
Closed

Rebase stable4 #16965

wants to merge 15 commits into from

Conversation

thewilsonator
Copy link
Contributor

No description provided.

rikkimax and others added 15 commits October 7, 2024 14:21
@rikkimax @thewilsonator
Document template instance duplication status as part of its field do…
7fac1ac 
…cumentation. (dlang#16643)
@kinke @thewilsonator
Fix Bugzilla 24599 - Wrongly elided TypeInfo emission (dlang#15868)
76de7ca 
Reverting dlang#14844, which caused such missing TypeInfos, *and* making
sure the special TypeInfo members are fully analyzed and ready for
codegen (otherwise hitting an assertion for the real-world project).
@rikkimax @thewilsonator
Reorganize backend build files to match target and make more similar …
0880ff2 
…per line (dlang#16672)
@dkorpel @thewilsonator
Remove redundant suggestions on linker errors (dlang#16711)
7879619
@dkorpel @thewilsonator
Fix bugzilla 24337 - Segfault when printing an int[] cast from a stri…
496dc7a 
…ng (dlang#16729)
@kinke @thewilsonator
Add BitFieldStyle.Gcc_Clang_ARM
0fe345d 
Required for 32-bit ARM, and non-Apple 64-bit ARM targets.

The only difference to `Gcc_Clang` is that anonymous and 0-length
bit-fields do contribute to the aggregate alignment.

Caught by existing proper C interop tests in
runnable_cxx/testbitfields.d on such targets. The hardcoded bad tests
in runnable/{bitfieldsposix64.c,dbitfieldsposix64.d} however now fail
after the fix, on such targets again.
@kinke @thewilsonator
[refactor to `TargetC.contributesToAggregateAlignment(BitFieldDeclara…
8fa13e3 
…tion)` hook]
@RazvanN7 @thewilsonator
Fix Bugzilla Issue 24687 - [REG2.110] Cannot cast string-imports to s…
403dbb1 
…elect overload anymore
@dkorpel @thewilsonator
Also make deprecationSupplemental adhere to error limit (dlang#16779)
6893869 
Co-authored-by: Dennis Korpel <dennis@sarc.nl>
@dkorpel @thewilsonator
Fix bugzilla 24699 - [REG2.108] No short-circuit evaluation of mixing…
a888535 
… template bool argument
@dkorpel @thewilsonator
Fix bugzilla 24731 - IFTI cannot handle integer expressions (dlang#16822
b1c98ae 
)
@RazvanN7 @thewilsonator
Fix Bugzilla Issue 24760 - ICE on variadic after default argument
0d6332e
@dkorpel @thewilsonator
Fix bugzilla 24790 - -vcg-ast ICE on lowered assign exp (dlang#16914)
1bd76dc 
Co-authored-by: Dennis Korpel <dennis@sarc.nl>
@dkorpel @thewilsonator
Fix bugzilla 24764 - ICE when -vcg-ast prints imported invariant (dla…
d4a8cd1 
…ng#16917)

Co-authored-by: Dennis Korpel <dennis@sarc.nl>
@dkorpel @thewilsonator
Fix bugzilla 24431 - dmd -vcg-ast crashes printing failed template in… (
c3b93cc 
dlang#16916)
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
✓ 24337 critical Segfault when printing an int[] cast from a string literal
✓ 24431 regression dmd -vcg-ast crashes printing failed template instantiation
✓ 24599 regression [REG2.103] Wrongly elided TypeInfo emission leading to undefined symbols at link-time
✓ 24687 regression [REG2.110] Cannot cast string-imports to select overload anymore
✓ 24699 regression [REG2.108] No short-circuit evaluation of mixing template bool argument
✓ 24731 normal IFTI cannot handle integer expressions
✓ 24760 normal ICE on variadic after default argument
✓ 24764 normal ICE when -vcg-ast prints imported invariant
✓ 24790 normal -vcg-ast ICE on lowered assign exp

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16965"

@thewilsonator thewilsonator deleted the rebase-stable4 branch October 7, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibuclaw ibuclaw Awaiting requested review from ibuclaw ibuclaw is a code owner

Assignees
No one assigned
Labels
Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thewilsonator @dlang-bot @rikkimax @kinke @dkorpel @RazvanN7