Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 11725: AA.dup should return mutable AA where possible #16979

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntrel
Copy link
Contributor

@ntrel ntrel commented Oct 9, 2024

Reboot of #2838.

  • Keeps same key type as I don't think there's any need to make that mutable.
  • Changes a unittest to a versioned function as it doesn't do any runtime tests.

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 9, 2024

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
11725 normal [AA] Cannot dup const AA

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#16979"

Since the original AA has been duplicated, it should be safe to mutate
the copy. No need to restrict the copy to be const too.
@ntrel
Copy link
Contributor Author

ntrel commented Oct 9, 2024

runnable/testaa3.d(118): Error: cannot cast [5:4] to int[int] at compile time

I don't know why that happens.

@ntrel ntrel marked this pull request as draft October 9, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants