Bit-shift expressions: Cast scalar right-hand-sides to vectors if needed #17064
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This promotion from scalar right-hand-sides to vectors already happens for the arithmetic binops, via
typeCombine()
side effects. Handle bit-shift expressions too now, by casting a scalar to the left-hand-side vector type.This can't be tested with DMD, as DMD's
Target.isVectorOpSupported()
doesn't support bit-shifts yet. It is ~required/useful for LDC though.