-
-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an assert-based segfault handler to etc.linux.memoryerror
#20643
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request and interest in making D better, @Reavershark! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#20643" |
The only way to solve this is to throw an exception. Anything else can cause memory and data corruption. |
Behavior currently depends on how the program calling
|
Additionally, note that for hardware exception signals like |
druntime/src/etc/linux/memoryerror.d
Outdated
* providing a more descriptive error message and stack trace if the program is | ||
* compiled with debug info and D assertions (as opposed to C assertions). | ||
* | ||
* Differences with version 1 are: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Differences with version 1 are: | |
* Differences with version registerMemoryErrorHandler are: |
Continuation of #15331.
Implements
registerMemoryAssertHandler
andderegisterMemoryAssertHandler
.Has some advantages over the existing
registerMemoryErrorHandler
:Some thoughts from the previous pr summarized:
Already determined that this breaks stack overflow detection.
SEGFAULT
this the only signal we want to be able to handle? What aboutSIGFPE
,SIGILL
,SIGBUS
...ucontext
be removed?