Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes fiber_entryPoint() noreturn #20959

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

denizzzka
Copy link
Contributor

@denizzzka denizzzka commented Mar 6, 2025

This makes fiber trampoline functions unnecessary? I.e., will this clear the "link register" prior to calling fiber_entryPoint?

upd: Most likely not, because this added assertion still needs to be catched somehow

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @denizzzka! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20959"

@denizzzka denizzzka force-pushed the noreturn_entrypoint branch from 8c3d761 to 91fbe07 Compare March 6, 2025 17:30
@denizzzka denizzzka marked this pull request as ready for review March 6, 2025 17:36
@denizzzka denizzzka marked this pull request as draft March 6, 2025 17:39
@denizzzka
Copy link
Contributor Author

fiber.d contains comment:

 * FIXME: fiber_entrypoint might benefit from a @noreturn attribute, but D doesn't have one.

@denizzzka denizzzka force-pushed the noreturn_entrypoint branch from 91fbe07 to 5935ee3 Compare March 6, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants