Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Migrate Win64-DMD-bootstrap job from Azure Pipelines to GHA #20973

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Mar 10, 2025

Pros:

Cons:

  • One more GHA job - with the default concurrency limit of 20 jobs

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20973"

@kinke kinke force-pushed the ci_away_from_azure branch 8 times, most recently from 79f9d6b to 2e50ad0 Compare March 11, 2025 00:17
@kinke kinke marked this pull request as ready for review March 11, 2025 00:44
@kinke kinke force-pushed the ci_away_from_azure branch from 2e50ad0 to 32b31f2 Compare March 11, 2025 01:02
if [ "$HOST_DMD_VERSION" = "2.079.0" ] ; then
# skip runnable_cxx and unit_tests with older bootstrap compilers
targets=("runnable" "compilable" "fail_compilation" "dshell")
args=() # use default set of args
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - this definitely accounted for longer runtimes specifically for the bootstrap job - it ran all default permutations, so incl. -release, and so doubling the number of compiler test permutations (16 vs. 8).

This is otherwise only enabled for Linux CI jobs:

dmd/ci/run.sh

Lines 119 to 124 in 9a8302a

# default to testing fewer compiler argument permutations to reduce CI load
if [ "$FULL_BUILD" == "true" ] && [ "$OS_NAME" == "linux" ]; then
local args=() # use all default ARGS
else
local args=(ARGS="-O -inline -release")
fi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants