Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I tried templatizing the _d_arrayliteralTX hook (Take a reference if needed from this PR) #20989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Prthmsh7
Copy link

#20970 I was trying to templatize _d_arrayliteralTX hook and implementing it completely but was facing the issue in implementing it in the compiler. I have created the template part and also kept the legacy version of it right below the template for ease. If anyone wishes to continues this work, I'm attaching this PR for a reference. Feel free to ask anything or any suggestions are welcome.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Prthmsh7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#20989"

@thewilsonator
Copy link
Contributor

If you are trying to find out how the compiler deals with that, start with git grep _d_arrayliteralTX, and look at the hits, look at the blame and find the PRs that introduced it and what PRs last touched it.

@Prthmsh7
Copy link
Author

If you are trying to find out how the compiler deals with that, start with git grep _d_arrayliteralTX, and look at the hits, look at the blame and find the PRs that introduced it and what PRs last touched it.

Yeah, Thanks actually, I was actually trying to do that earlier and then I got stuck somewhere. I think I should get back to this issue after some time. Also, I removed the few things that I initially added. I guess it would be better for the upcoming contributor to write the required test case and other stuff from the scratch for their ease, as the code started to become a bit messy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants