fix #18614 RTInfo generation can fail for structs defined in imported modules #21812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orted modules allow RTInfo to be generated from the glue layer as similar members of the TypeInfo, e.g. xeq and xcmp. it is unnecessary to skip deprecated structs, as Scope's STC.deprecated_ takes care of muting deprecation messages.
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.
|
rainers
commented
Sep 5, 2025
| // Instantiate RTInfo!S to provide a pointer bitmap for the GC | ||
| // Don't do it in -betterC or on unused deprecated / error types | ||
| if (!ad.getRTInfo && global.params.useTypeInfo && Type.rtinfo && | ||
| (!ad.isDeprecated() || global.params.useDeprecated != DiagnosticReporting.error) && |
Member
Author
There was a problem hiding this comment.
This line is removed in the moved code as it is now unnecessary to skip deprecated structs. Scope's STC.deprecated_ takes care of muting deprecation messages.
thewilsonator
requested changes
Sep 5, 2025
Contributor
thewilsonator
left a comment
thewilsonator
left a comment
There was a problem hiding this comment.
Otherwise looks good
rainers
commented
Sep 5, 2025
| if (!sd.members) | ||
| return; | ||
|
|
||
| if (sd.semanticRun < PASS.semantic3done) |
Member
Author
There was a problem hiding this comment.
This should not be checked for templates only, as an incomplete TypeInfo can replace the correct one (compiled into the source modules object file) when linking.
thewilsonator
approved these changes
Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow RTInfo to be generated from the glue layer as similar members of the TypeInfo, e.g. xeq and xcmp.
This is simpler solution than #2480, but calling back semantic analysis from the glue layer is more of a workaround that takes advantage of the simplicity of the RTInfo template that just evaluates a __traits(getPointerBitmap).