fix Issue 15900 - public imports not accessible using FQN#5967
Merged
WalterBright merged 2 commits intodlang:stablefrom Jul 30, 2016
Merged
fix Issue 15900 - public imports not accessible using FQN#5967WalterBright merged 2 commits intodlang:stablefrom
WalterBright merged 2 commits intodlang:stablefrom
Conversation
Contributor
Member
Author
|
Need to fix Travis-CI testing of stable branch (it's checking out druntime/phobos) master atm., please ignore the failures, but only this time ;). |
Member
Author
|
Finally fixed all the testing issues with stable, both for Travis-CI and the auto-tester. |
Contributor
FYI The windows machines still seem to fail :/ |
- public imports in imported modules were not accessbile using their FQN, this was an oversight when adding the package tree masking to fix Bugzilla 313 (see dlang#5426) - fixed by recursively checking imported scopes for accessible packages - reuse Module.insearch to not follow import cycles - Uses the same reduced visibility distinction (only private vs. rest) as the unqualified symbol search, b/c extending importedScopes to track rich visibility (e.g. package(a.b)) was out of scope for a regression fix. This should be implemented when combining the search/import w/ the symbol visibility mechanism.
- this is also fixed by searching the importedScopes for accessible packages
Member
|
Auto-merge toggled on |
Member
Author
Got fixed here, had to handle public import cycles. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FQN, this was an oversight when adding the package tree masking to fix
Bugzilla 313 (see fix Issue 313 - Fully qualified names bypass private imports #5426)
unqualified symbol search, b/c extending importedScopes to track rich
visibility (e.g. package(a.b)) was out of scope for a regression fix.
This should be implemented when combining the search/import w/
the symbol visibility mechanism.
by searching the importedScopes for accessible packages