Skip to content

Set coverage destination directory to source directory#6006

Merged
WalterBright merged 1 commit intodlang:masterfrom
wilzbach:set_coverage_dest
Aug 3, 2016
Merged

Set coverage destination directory to source directory#6006
WalterBright merged 1 commit intodlang:masterfrom
wilzbach:set_coverage_dest

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Aug 3, 2016

After looking a bit at the output from CodeCov I realized why the test folder appears there. The .lst files are stored in the current working directory and CodeCov tries to match them via name to the nearest file it finds, so for example it finds a file imphint.d in the test directory too and thus tries to match them.

The fix is simple ;-)

@codecov-io
Copy link

codecov-io commented Aug 3, 2016

Current coverage is 87.17% (diff: 100%)

Merging #6006 into master will increase coverage by <.01%

@@             master      #6006   diff @@
==========================================
  Files            89         89          
  Lines         55678      55679     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          48536      48537     +1   
  Misses         7142       7142          
  Partials          0          0          

Powered by Codecov. Last update 4339176...b7aace0

@WalterBright
Copy link
Member

Now that it's working, could you please:

  1. check that it is using only the free instance
  2. what happens when we exceed the 1500 allotted minutes?
  3. can you please expedite the changes to not link or run the test files?

@WalterBright
Copy link
Member

Auto-merge toggled on

@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 3, 2016

  1. check that it is using only the free instance

Looks good:

image

Btw if we get their ok you can set the number of instances used here:

image

  1. what happens when we exceed the 1500 allotted minutes?

Idk, it might be that just by being public on Github we get the option with 4 containers - I am still waiting for their reply, though. In the worst case scenario it will stop building for the end of the month.

image

  1. can you please expedite the changes to not link or run the test files?

Will have a look at it this evening ;-)

@WalterBright WalterBright merged commit 95bda33 into dlang:master Aug 3, 2016
@WalterBright
Copy link
Member

Thank you. My concern with what happens when the 1500 minutes runs out is they start automatically billing us, and we may get an unexpected humungous bill. Also, not linking, etc., will stretch out our time allotment.

I'm not actually averse to paying for the service if it turns out to be productive for us and the price is reasonable. But I still want to be parsimonious and minimize our usage of it to just what is necessary.

@wilzbach wilzbach deleted the set_coverage_dest branch August 3, 2016 09:54
@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 3, 2016

Thank you. My concern with what happens when the 1500 minutes runs out is they start automatically billing us, and we may get an unexpected humungous bill. Also, not linking, etc., will stretch out our time allotment.

I skipped over their TOS and couldn't find any any cruel bits (disclaimer: I am not a lawyer).
The only thing I found is that they can increase their pricing with 30 days notice.

Licensee shall pay CircleCI the fees set forth in an Order in accordance with the terms set forth therein; provided that CircleCI may change any applicable fees upon thirty (30) days’ notice at any time and such new fees shall become effective for any subsequent renewal Term.

Maybe someone else here with more legal experience can help to relieve Walter?

I'm not actually averse to paying for the service if it turns out to be productive for us and the price is reasonable.

It's still an experiment. Let's see how it goes ;-)

@wilzbach
Copy link
Contributor Author

wilzbach commented Aug 4, 2016

@WalterBright I just found the following in the settings at the org page

Additionally, projects that are public on GitHub will build with 3 extra containers -- our gift to free and open source software.

and then this in their FAQ

What if I am building open-source?

We offer a total of four free linux containers ($2400 annual value) for open-source projects. Simply keeping your project public will enable this for you!

You should be able to set the number of container here. I guess two containers per build (for 32-bit & 64-bit) is enough for now?

Btw among other settings they also have the feature to "auto-cancel redundant builds".

(FYI I don't have access to these settings, but I can see them for mir, hence I know how the links should be)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants