taking address of local means it cannot be 'scope' later #6328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinNowak
reviewed
Dec 18, 2016
| { | ||
| int i; | ||
| int* f; | ||
| scope int** x = &f; |
Member
There was a problem hiding this comment.
A bit surprising that this doesn't work, because lifetime(x) < lifetime(f). Also int i; scope int* p = &i; on it's own does work, doesn't it?
If lifetime(*x) simply was defined as lifetime(x), there wouldn't be a way to escape the pointer to f, but I'm not sure how much DIP1000 still relates to any of the implementation at this point.
Member
Author
There was a problem hiding this comment.
It does work. It's the next line that fails (because now f cannot be scope).
Member
There was a problem hiding this comment.
What I meant was that transitivity could work here, i.e. a scope pointer to a scope pointer, exactly b/c lifetime(x) < lifetime(f)
MartinNowak
added
Merge:auto-merge
auto-merge-squash
and removed
Merge:auto-merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.