Skip to content

build samples when the auto tester runs the win32 test suite#6709

Merged
WalterBright merged 2 commits intodlang:masterfrom
rainers:build_samples
Apr 19, 2017
Merged

build samples when the auto tester runs the win32 test suite#6709
WalterBright merged 2 commits intodlang:masterfrom
rainers:build_samples

Conversation

@rainers
Copy link
Member

@rainers rainers commented Apr 18, 2017

also fixes htmlget.d

@WalterBright
Copy link
Member

Nice! But it fails on windows with:

cd samples
f win32.mak
Error: 'f' not found

@rainers
Copy link
Member Author

rainers commented Apr 18, 2017

It seems $(MAKE) suddenly expands to nothing. I've amended a different version.

@rainers
Copy link
Member Author

rainers commented Apr 18, 2017

It's again the auto tester complicating the build with unnecessary patching of makefiles.

@braddr
Copy link
Member

braddr commented Apr 18, 2017

Sigh, that's likely something I'll need to help handle. That's one area that I specifically patch on the auto-testers, I believe. Sorry for the complications, but if it wasn't needed, I wouldn't be doing it. More later tonight or tomorrow.

@rainers rainers force-pushed the build_samples branch 5 times, most recently from b46c492 to d10f3fa Compare April 19, 2017 07:25
@WalterBright WalterBright merged commit a838340 into dlang:master Apr 19, 2017
@rainers
Copy link
Member Author

rainers commented Apr 20, 2017

Sorry for the complications, but if it wasn't needed, I wouldn't be doing it.

In this case, can't you just add MAKE="gmake -j3" to the command line instead of patching the file?

Even if command line arguments don't work, adding a special target and configuration/code to the standard repo for the auto-tester would be better than patching. I know some defaults in makefiles are bad, but the current way of handling this prevents improvements, e.g. dlang/phobos#2526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants