build samples when the auto tester runs the win32 test suite#6709
build samples when the auto tester runs the win32 test suite#6709WalterBright merged 2 commits intodlang:masterfrom
Conversation
|
Nice! But it fails on windows with: |
|
It seems $(MAKE) suddenly expands to nothing. I've amended a different version. |
|
It's again the auto tester complicating the build with unnecessary patching of makefiles. |
|
Sigh, that's likely something I'll need to help handle. That's one area that I specifically patch on the auto-testers, I believe. Sorry for the complications, but if it wasn't needed, I wouldn't be doing it. More later tonight or tomorrow. |
b46c492 to
d10f3fa
Compare
fix htmlget.d
In this case, can't you just add MAKE="gmake -j3" to the command line instead of patching the file? Even if command line arguments don't work, adding a special target and configuration/code to the standard repo for the auto-tester would be better than patching. I know some defaults in makefiles are bad, but the current way of handling this prevents improvements, e.g. dlang/phobos#2526 |
also fixes htmlget.d