Skip to content

Fix ASTNull#6720

Merged
MartinNowak merged 1 commit intodlang:masterfrom
davispuh:astnull
Apr 23, 2017
Merged

Fix ASTNull#6720
MartinNowak merged 1 commit intodlang:masterfrom
davispuh:astnull

Conversation

@davispuh
Copy link
Contributor

@davispuh davispuh commented Apr 22, 2017

15b6ac7 addded

Parser!ASTNull(null, null, false)

which crashes

object.Error@(0): Access Violation
----------------
0x005E0673 in ddmd.lexer.Lexer ddmd.lexer.Lexer.__ctor(const(char)*, const(char)*, uint, uint, bool,bool) at dmd\src\ddmd\lexer.d(189)
0x004E6ADF in ddmd.parse.Parser!(ddmd.astnull.ASTNull).Parser ddmd.parse.Parser(ddmd.astnull.ASTNull).Parser.__ctor(ddmd.astnull.ASTNull.Module, const(char)[], bool) at dmd\src\ddmd\parse.d(275)
0x004D4A07 in void ddmd.parse.__unittestL8426_10() at dmd\src\ddmd\parse.d(8429)
0x004F84AC in void ddmd.parse.__modtest()
0x005F105D in scope int core.runtime.runModuleUnitTests().__foreachbody1(scopeobject.ModuleInfo*)
0x005EE80B in scope int object.ModuleInfo.opApply(scope intdelegate(object.ModuleInfo*)).__lambda2(immutable(object.ModuleInfo*))

Parser!ASTNull(null, null, false)
@UplinkCoder
Copy link
Member

@davispuh change commit message please.

@MartinNowak MartinNowak merged commit 02d131d into dlang:master Apr 23, 2017
@UplinkCoder
Copy link
Member

@MartinNowak can you fix the commit message by doing a rebase -i into check for source !is null berfore parsing ?

@jacob-carlborg
Copy link
Contributor

Just as 15b6ac7, this was merged a bit too soon. Unit tests, that is unittest blocks inside the DMD source code, are not run as part of the regular test suite.

@MartinNowak @davispuh @RazvanN7

@wilzbach
Copy link
Contributor

Unit tests, that is unittest blocks inside the DMD source code, are not run as part of the regular test suite.

-> #6767

@jacob-carlborg
Copy link
Contributor

-> #6767

That's great 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments