Skip to content

Generate id.d and id.h using "dmd -run idgen.d" instead of compiling#6735

Closed
marler8997 wants to merge 1 commit intodlang:masterfrom
marler8997:idgenrun
Closed

Generate id.d and id.h using "dmd -run idgen.d" instead of compiling#6735
marler8997 wants to merge 1 commit intodlang:masterfrom
marler8997:idgenrun

Conversation

@marler8997
Copy link
Contributor

Simple build simplification. Run idgen.d directly using "dmd -run" instead of compiling and running in 2 seperate steps.

@yebblies
Copy link
Contributor

This is what it used to do, but it was changed. I don't remember why it was changed, but it needs to be worked out before it is changed back.

marler8997@aa8a7b3

@UplinkCoder
Copy link
Member

Probably such that it does not have to needlessly recompile it.

@marler8997
Copy link
Contributor Author

@UplinkCoder There's a makefile rule for it, it should only be compiled once. Actually this method will likely result in less recompilation since it seems that the "generated" directory where the idgen binary lives is cleaned for each run of make. By using the method in this PR there is no intermediate binary that gets cleaned every time so it should only recompile when idgen.d actually changes.

@yebblies yebblies requested a review from MartinNowak May 4, 2017 09:26
@wilzbach
Copy link
Contributor

wilzbach commented Jun 8, 2017

Related PR: #6837 (Replace idgen with CTFE implementation)

@jacob-carlborg
Copy link
Contributor

Yeah, since #6837 has been merged, I would say this PR is obsolete.

@wilzbach
Copy link
Contributor

Yeah, since #6837 has been merged, I would say this PR is obsolete.

Agreed, thanks for the work @marler8997, but in this case I think the merged CTFE approach is simpler and more flexible.

@wilzbach wilzbach closed this Aug 13, 2017
@marler8997 marler8997 deleted the idgenrun branch August 15, 2017 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants