fix Issue 17495 - __traits(getParameterStorageClasses) doesn't work w…#6897
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jun 13, 2017
Merged
fix Issue 17495 - __traits(getParameterStorageClasses) doesn't work w…#6897dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
WalterBright
added
the
Review:Blocking Other Work
Contributor
|
rainers
reviewed
Jun 12, 2017
| ex = ex.ctfeInterpret(); | ||
| auto ii = ex.toUInteger(); | ||
| if (ii >= fparams.dim) | ||
| if (ii >= Parameter.dim(fparams)) |
Member
There was a problem hiding this comment.
I suspect the error message should show the new upper limit, too.
…ith tuples as parameters
Member
|
So these are the other issue, right? ../../.dub/packages/libasync-0.8.3/libasync/source/libasync/events.d(57,2): Error: destructor 'libasync.events.EventLoop.~this' is not nothrow
../../.dub/packages/libasync-0.8.3/libasync/source/libasync/events.d(57,2): Error: nothrow constructor 'libasync.events.EventLoop.this' may throw |
Member
The fix for the libasync error is here: |
Member
Author
It's the issue for getParameterStorageClassTuples. It's a bug, regardless, and the fix for it. |
rainers
approved these changes
Jun 13, 2017
WalterBright
removed
the
Review:Blocking Other Work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ith tuples as parameters
blocking dlang/phobos#5474