Skip to content

Fix #6821 changelog entry#6912

Merged
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170617-032257
Jun 17, 2017
Merged

Fix #6821 changelog entry#6912
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170617-032257

Conversation

@CyberShadow
Copy link
Member

This is a partial revert of 0d40de4. This commit introduced a number of problems:

  1. The title was two lines, which did not conform to the syntax as described in README.md, and caused the generated changelog to be misformed (see http://dlang.org/changelog/2.075.0_pre.html)

  2. There was trailing whitespace on the second line, causing dlang.org's test target to fail

  3. Subjectively, I'm having trouble understanding the new wording. The old wording was much more concise, and if it was factually incorrect, I don't see how.

CC @UplinkCoder @wilzbach

This is a partial revert of
0d40de4. This commit introduced a
number of problems:

1. The title was two lines, which did not conform to the syntax as
described in README.md, and caused the generated changelog to be
misformed (see http://dlang.org/changelog/2.075.0_pre.html)

2. There was trailing whitespace on the second line, causing
dlang.org's test target to fail

3. Subjectively, I'm having trouble understanding the new wording. The
old wording was much more concise, and if it was factually incorrect,
I don't see how.
@CyberShadow CyberShadow added the Review:Trivial typos, formatting, comments label Jun 17, 2017
Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wilzbach
Copy link
Contributor

This commit introduced a number of problems:
The title was two lines, which did not conform to the syntax as described in README.md, and caused the generated changelog to be misformed (see http://dlang.org/changelog/2.075.0_pre.html)
There was trailing whitespace on the second line, causing dlang.org's test target to fail

That's why I'm setting it directly to auto-deploy merge.
@UplinkCoder I hardly doubt that you have anything against this, but if so, we can always do this, once the test target is green again and we have enabled an enforcement check for its passing it ;-)

@dlang-bot dlang-bot merged commit 8dc55b3 into dlang:master Jun 17, 2017
@UplinkCoder
Copy link
Member

It's fine.
Unfortunately I am not used to ddoc :)

CyberShadow added a commit to CyberShadow/tools that referenced this pull request Jun 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants