Skip to content

Actually fix path of generated DMD#6916

Merged
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170618-002833
Jun 19, 2017
Merged

Actually fix path of generated DMD#6916
dlang-bot merged 1 commit intodlang:masterfrom
CyberShadow:pull-20170618-002833

Conversation

@CyberShadow
Copy link
Member

@CyberShadow CyberShadow commented Jun 18, 2017

As OS was never defined, it was substituted as an empty string in the G variable.

This is a fixup for #6873.

I don't see where OS is being set by the autotester (if anywhere) - if it's not, then it's still using the current path hierarchy instead of the intended POSIX one. Let's see what the autotester says.

@CyberShadow
Copy link
Member Author

I don't see where OS is being set by the autotester (if anywhere)

OK, I see. The win32.mak makefile still creates a dmd\src\dmd.exe file, which the auto-tester still uses.

I've confirmed that this pull request fixes CyberShadow/Digger#58 (thus making the path actually the same as on POSIX), and the build seems to be succeeding on the auto-tester Windows hosts.

CC @RazvanN7

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@WalterBright
Copy link
Member

In the future, please use more illuminating branch names than pull-20170618-002833 which gives no clue what this might be about. Something like path-of-DMD.

@CyberShadow
Copy link
Member Author

Sorry, that's part of an automated part of my workflow, and is not going to change. Please look at the commits in the branch or the PR title or description.

@dlang-bot dlang-bot merged commit ef303b4 into dlang:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments