Actually fix path of generated DMD#6916
Merged
dlang-bot merged 1 commit intodlang:masterfrom Jun 19, 2017
Merged
Conversation
Member
Author
OK, I see. The win32.mak makefile still creates a I've confirmed that this pull request fixes CyberShadow/Digger#58 (thus making the path actually the same as on POSIX), and the build seems to be succeeding on the auto-tester Windows hosts. CC @RazvanN7 |
andralex
approved these changes
Jun 18, 2017
Member
|
In the future, please use more illuminating branch names than |
Member
Author
|
Sorry, that's part of an automated part of my workflow, and is not going to change. Please look at the commits in the branch or the PR title or description. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
OSwas never defined, it was substituted as an empty string in theGvariable.This is a fixup for #6873.
I don't see where
OSis being set by the autotester (if anywhere) - if it's not, then it's still using the current path hierarchy instead of the intended POSIX one. Let's see what the autotester says.