Skip to content

Conversation

@WalterBright
Copy link
Member

Add some direct links to the Spec corresponding to Expression nodes.

@WalterBright WalterBright added the Review:Trivial typos, formatting, comments label Aug 5, 2017
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @WalterBright!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@rainers
Copy link
Member

rainers commented Aug 5, 2017

As these are Ddoc comments they show up in the generated documentation, but pretty badly formatted, e.g. http://dtest.dlang.io/artifact/website-cd3a65fbdfa0ddac41d309455d4d0930aae7f507-21a8c51d507707f7cc0c3ed83ac6ef26/web/library-prerelease/ddmd/expression/add_exp.html

@WalterBright
Copy link
Member Author

badly formatted

That was fixed by #7043

@wilzbach
Copy link
Contributor

wilzbach commented Aug 6, 2017

That was fixed by #7043

Only for Ddoc, not Ddox.
It might help adoption of a Ddoc change to all the other documentation engines if it's accompanied by a spec change...

@rainers
Copy link
Member

rainers commented Aug 6, 2017

That was fixed by #7043

It doesn't show up in the documentation, e.g. http://dtest.dlang.io/artifact/website-3bb580a55554d33712e17e39578e8b7f7164c90d-8057772f27d802cf0c39fec5774f95d6/web/phobos/ddmd_expression.html
Is that the fix or is the build outdated?

@WalterBright
Copy link
Member Author

It doesn't show up in the documentation

If the documentation isn't built by master, than it wouldn't show up.

@WalterBright
Copy link
Member Author

a spec change

dlang/dlang.org#1858

@rainers
Copy link
Member

rainers commented Aug 8, 2017

If the documentation isn't built by master, than it wouldn't show up.

Unfortunately, the logs are not accessible if the build succeeds, so can't check that. I've verified locally that it works, though.

@rainers
Copy link
Member

rainers commented Aug 8, 2017

It's a bit ugly though, as the comments end up on a single line, e.g.

econd ? e1 : e2 http://dlang.org/spec/expression.html#conditional_expressions TOKquestion 

@WalterBright
Copy link
Member Author

It's a bit ugly though, as the comments end up on a single line, e.g.

Fixed

@dlang-bot dlang-bot merged commit 71e1cec into dlang:master Aug 14, 2017
@WalterBright WalterBright deleted the explinks branch August 15, 2017 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants