refactor: add parseCommandLine()#7084
Merged
dlang-bot merged 2 commits intodlang:masterfrom Aug 19, 2017
Merged
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
a19a25e to
4a29c4c
Compare
4a29c4c to
bd05aad
Compare
Contributor
|
Since you're going through the work of refactoring this entire file, is it possible to start using D's string facilities instead of C's |
Member
Author
|
Yes, but my main concern is better encapsulation, rather than a tangle of dependencies. |
Contributor
|
If your main concern is a dependency on Phobos, I understand. But what about just druntime where |
Member
Author
|
By encapsulation I mean having clear inputs and outputs. Dependency on Phobos is a separate issue. |
3083158 to
48783d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just pulls the code that loops over
arguments[]intoparseCommandLine(). You can't really tell that from the github diff, as github gets thoroughly confused.This makes the inputs and outputs for parsing the command line clear, and removes the global variable references from it. All instances of
global.paramsinparseCommandLine()are replaced with justparams. It's much better encapsulated.More can be done, but this is a good first approximation.