Skip to content

Removed unexisting idgen.d from win32 makefile#7181

Merged
dlang-bot merged 1 commit intodlang:masterfrom
jercaianu:master
Oct 6, 2017
Merged

Removed unexisting idgen.d from win32 makefile#7181
dlang-bot merged 1 commit intodlang:masterfrom
jercaianu:master

Conversation

@jercaianu
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @jercaianu! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@andralex
Copy link
Member

andralex commented Oct 6, 2017

@RazvanN7 @WalterBright what's the deal with this? I'll pull because all tests pass.

@dlang-bot dlang-bot merged commit 1e76c14 into dlang:master Oct 6, 2017
@PetarKirov
Copy link
Member

@andralex Since #6837 dmd identifier generation was transitioned from a build step to CTFE, so this PR is correct in removing idgen.d. I wonder however why the auto-tester didn't catch this in #6837...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants