improve back end debug printing of intermediate code#7360
Merged
WalterBright merged 1 commit intodlang:masterfrom Dec 1, 2017
Merged
improve back end debug printing of intermediate code#7360WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
stefan-koch-sociomantic
approved these changes
Nov 27, 2017
stefan-koch-sociomantic
left a comment
stefan-koch-sociomantic
left a comment
There was a problem hiding this comment.
This is a step into the right direction.
JinShil
suggested changes
Dec 1, 2017
| if (b->Belem) elem_print(b->Belem); | ||
| if (b->Belem) | ||
| { | ||
| if (0) |
Contributor
There was a problem hiding this comment.
Should this be false instead of 0?
Member
Author
There was a problem hiding this comment.
0 is never going to be an incorrect argument to if.
JinShil
approved these changes
Dec 1, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a lot easier to read when blocks are numbered rather than random pointer values.