Make deprecation warnings compile errors #7389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Member
|
Looks like this needs some code fixes first as well. |
wilzbach
force-pushed
the
deprecation-error
branch
from
1a3f0ae to
29985e7
Compare
wilzbach
force-pushed
the
deprecation-error
branch
from
29985e7 to
4809740
Compare
Contributor
Author
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already the way we build Phobos + Tools.
See also: dlang/phobos#5546
The idea is that whenever sth. gets deprecated in Druntime or Phobos a replacement needs to exists. By always building with
-de, we can enforce that the replacement really exists and force the person who submits the deprecation to look after the fallout.CC @ZombineDev @CyberShadow