Skip to content

Fix OSX build after changed C++ mangling#7519

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-travis2
Closed

Fix OSX build after changed C++ mangling#7519
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:fix-travis2

Conversation

@wilzbach
Copy link
Contributor

See #7416 and #7505

Still missing are these:

Undefined symbols for architecture x86_64:
  "symboldata(unsigned long, unsigned int)", referenced from:
      el_ptr(Symbol*) in backend.a(el.o)
      el_convstring(elem*) in backend.a(el.o)
      out_readonly_sym(unsigned int, void*, int) in backend.a(out.o)
      Obj::sym_cdata(unsigned int, char*, int) in backend.a(machobj.o)
  "_align(unsigned long, unsigned long)", referenced from:
      codgen(Symbol*) in backend.a(cgcod.o)
      stackoffsets(int) in backend.a(cgcod.o)
      outjmptab(block*) in backend.a(cod3.o)
      outswitab(block*) in backend.a(cod3.o)
      type_paramsize(TYPE*) in backend.a(type.o)
      alignOffset(int, unsigned long) in backend.a(out.o)
      out_readonly_sym(unsigned int, void*, int) in backend.a(out.o)
      ...
  "ispow2(unsigned long long)", referenced from:
      asmSemantic(AsmStatement*, Scope*) in dmd.o
  "outthunk(Symbol*, Symbol*, unsigned int, unsigned int, unsigned long long, int, unsigned long long)", referenced from:
      toThunkSymbol(FuncDeclaration*, int) in dmd.o
  "Obj::ehtables(Symbol*, unsigned long long, Symbol*)", referenced from:
      except_gentables() in dmd.o

But I'm without OSX, so I first wanted to see whether I'm on the right road here.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach added the Review:WIP Work In Progress - not ready for review or pulling label Dec 25, 2017
* Write a size_t value.
*/
void DtBuilder::size(d_ulong value)
void DtBuilder::size(unsigned long value)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is replacing a 64 bit integer with a 32 bit integer. It cannot work correctly.

@wilzbach wilzbach closed this Dec 26, 2017
@wilzbach wilzbach deleted the fix-travis2 branch March 13, 2018 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:WIP Work In Progress - not ready for review or pulling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants