Implement -probe for showing supported features #7521

wilzbach · 2017-12-26T00:08:32Z

DUB creates a special platform probe file on every invocation, (more details).

(determinePlatform is called by setupPackage in execute)

While DUB should cache this invocation, I think there should be a "standard" format for feature detection instead of using this hack to generate a D file with version identifiers.
This PR generates the same output as the generated DUB probing file, e.g.:

{

    "compiler": "dmd",
    "frontendVersion": 2078,
    "compilerFrontend": "v2.078.0-beta.1-113-g057aa4442",
    "config": null,
    "binary": "/home/seb/dlang/dmd/generated/linux/release/64/dmd",
    "platform": [
        "posix",
        "linux"
    ],
    "architecture": [
        "x86_64"
    ],
    "predefinedVersions": [
        "DigitalMars",
        "Posix",
        "linux",
        "ELFv1",
        "LittleEndian",
        "D_Version2",
        "all",
        "D_SIMD",
        "D_InlineAsm_X86_64",
        "X86_64",
        "CRuntime_Glibc",
        "D_LP64",
        "D_PIC",
        "assert",
        "D_HardFloat"
    ]
}

(I didn't add this flag to the documentation, s.t. it can stay an experiment)

dlang-bot · 2017-12-26T00:08:33Z

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2017-12-26T00:20:52Z

(CC @s-ludwig who is using this in DUB)

ibuclaw · 2017-12-26T17:23:38Z

src/dmd/probing.d

+
+private void determinePlatform(void delegate(string) print)
+{
+	version(Windows) print("windows");


This is wrong. Don't you want to print target information, not host?

ibuclaw · 2017-12-26T17:23:49Z

src/dmd/probing.d

+
+private void determineArchitecture(void delegate(string) print)
+{
+	version(X86) print("x86");


Likewise here.

JinShil · 2017-12-27T04:30:35Z

src/dmd/probing.d

+ * License:     $(LINK2 http://www.boost.org/LICENSE_1_0.txt, Boost License 1.0)
+ * Source:      $(LINK2 https://github.com/dlang/dmd/blob/master/src/dmd/mars.d, _mars.d)
+ * Documentation:  https://dlang.org/phobos/dmd_mars.html
+ * Coverage:    https://codecov.io/gh/dlang/dmd/src/master/src/dmd/mars.d


This documentation header seems to be cut and pasted from mars.d, but needs to be updated for this file.

mathias-lang-sociomantic · 2017-12-29T13:30:41Z

src/dmd/probing.d

+	else version(GNU) return "gdc";
+	else version(LDC) return "ldc";
+	else version(SDC) return "sdc";
+	else return null;


That also looks wrong, since it gives the name of the compiler used to compile this file.

mathias-lang-sociomantic · 2017-12-29T13:32:29Z

src/dmd/probing.d

+	version(SH64) print("sh64");
+	version(Alpha) print("alpha");
+	version(Alpha_SoftFP) print("alpha_softfp");
+	version(Alpha_HardFP) print("alpha_hardfp");


Then leave it out ? No point in faking support, especially given those targets are more likely to be subject to cross compilation.

s-ludwig · 2017-12-29T13:34:44Z

Wouldn't slightly a more generic functionailty make more sense, where simply all predefined versions are dumped to stdout?

ibuclaw · 2017-12-29T13:43:50Z

Wouldn't slightly a more generic functionailty make more sense, where simply all predefined versions are dumped to stdout?

They are with -v.

dmd/src/dmd/mars.d

Lines 1428 to 1437 in a6515d1

    
           private void printPredefinedVersions() 
        
           { 
        
               if (global.params.verbose && global.params.versionids) 
        
               { 
        
                   fprintf(global.stdmsg, "predefs  "); 
        
                   foreach (const s; *global.params.versionids) 
        
                       fprintf(global.stdmsg, " %s", s); 
        
                   fprintf(global.stdmsg, "\n"); 
        
               } 
        
           }

wilzbach · 2017-12-29T15:17:33Z

They are with -v.

It doesn't do this anymore: #7549

Wouldn't slightly a more generic functionailty make more sense, where simply all predefined versions are dumped to stdout?

Good idea (done), but I think you will still need things like frontendVersion for DUB too, right?

s-ludwig · 2018-01-04T08:52:58Z

Good idea (done), but I think you will still need things like frontendVersion for DUB too, right?

True, would be good to avoid another process invocation for that (--version), at least on Windows...

wilzbach · 2018-01-08T15:29:46Z

@s-ludwig so -probe would work for you? Anything else that's missing/blocking?

timotheecour · 2018-01-20T10:32:00Z

how about a more flexible way to output exactly what we want:

-probe=version,import,default_version,deps,file=out.txt (etc, easily extensible without breaking client clode)
it would output in json (easier to parse) (or maybe allow -probe=...,format=txt)
if file is not specified, goes to stdout
advantage: if some probes are large or slow down compilation, could be wasteful to add them unless they're explicitly asked for.

NOTE: -v can't change too much unfortunately for backward compatibility reasons, but -probe could be well designed since we're starting from scratch and future proof.

NOTE: precedent for this:
dub describe --data="lflags, libs, linker-files" (similar syntax)

FYI @marler8997 @wilzbach @s-ludwig

marler8997 · 2018-01-20T16:24:25Z

graphql for dmd :)

timotheecour · 2018-01-22T08:52:26Z

could -Xf (json output) used instead of introducing another -probe flag? (cf #7757)

wilzbach · 2018-01-22T17:52:43Z

how about a more flexible way to output exactly what we want:

I like the idea, but isn't this an overkill? The JSON file is really tiny at the moment (see the first comment) and it's unlikely that it will get bigger

NOTE: -v can't change too much unfortunately for backward compatibility reasons, but -probe could be well designed since we're starting from scratch and future proof.

I don't see why - if this advanced selection was ever needed - it couldn't be added to -probe. After all, -probe currently takes no argument and detecting the special case when a user gives it an argument isn't too hard.

could -Xf (json output) used instead of introducing another -probe flag?

Problems I see

-probe doesn't require a file input and won't do any serious work. Thus it's very cheap to call. It's like -version
-probe uses stdout by default
you proposed to allow alternative formats for -probe - how would that work with -Xf?

We could rename -probe to e.g. -version=json if you don't like to have a new flag.

CyberShadow · 2018-01-22T20:10:24Z

I like Timothee's idea from here, where dmd -Xf without input files produces the same information as -probe would. It would mean one less switch and one less format, and would let programs that need to compile something and get compiler information to do so with one compiler invocation.

timotheecour · 2018-01-22T20:15:10Z

the link u gave is wrong, I think you meant dlang/tools#292 (comment) :)

marler8997 · 2018-02-04T16:55:38Z

Alternative to -probe submitted here: #7838

wilzbach · 2018-02-15T05:11:04Z

Superseded by #7894

wilzbach requested review from CyberShadow, MartinNowak and WalterBright as code owners December 26, 2017 00:08

wilzbach mentioned this pull request Dec 26, 2017

Platform probing can be replaced with dmd -Xi=compilerInfo -Xf=- for newer compilers dlang/dub#1317

Open

ibuclaw reviewed Dec 26, 2017

View reviewed changes

JinShil reviewed Dec 27, 2017

View reviewed changes

mathias-lang-sociomantic reviewed Dec 29, 2017

View reviewed changes

wilzbach force-pushed the probing branch 3 times, most recently from aa118b4 to 0900e80 Compare December 29, 2017 15:16

wilzbach force-pushed the probing branch from 0900e80 to 3e35c61 Compare December 29, 2017 15:22

dlang-bot added Review:Needs Rebase Review:Needs Work and removed Review:Needs Rebase Review:Needs Work labels Jan 1, 2018

wilzbach force-pushed the probing branch from 3e35c61 to b46d513 Compare January 3, 2018 05:15

dlang-bot added the Review:Needs Work label Jan 4, 2018

dlang-bot added the Review:Needs Rebase label Jan 5, 2018

wilzbach force-pushed the probing branch from b46d513 to 0f4b507 Compare January 8, 2018 00:00

dlang-bot added Review:Needs Work and removed Review:Needs Work Review:Needs Rebase labels Jan 8, 2018

dlang-bot added Review:Needs Work and removed Review:Needs Work labels Jan 8, 2018

wilzbach force-pushed the probing branch from 40352b7 to 7f296b4 Compare January 8, 2018 15:28

dlang-bot removed the Review:Needs Work label Jan 8, 2018

dlang-bot added Review:Needs Work Review:Needs Rebase labels Jan 8, 2018

wilzbach force-pushed the probing branch from 7f296b4 to 89ab2d6 Compare January 17, 2018 02:29

wilzbach requested a review from rainers as a code owner January 17, 2018 02:29

dlang-bot removed Review:Needs Work Review:Needs Rebase labels Jan 17, 2018

Implement -probe for showing supported features

55ea88f

wilzbach force-pushed the probing branch from 89ab2d6 to 55ea88f Compare January 19, 2018 02:26

wilzbach mentioned this pull request Jan 20, 2018

Allow verbose output to be directed to a file #7746

Closed

timotheecour mentioned this pull request Jan 22, 2018

Add support for the -i interface and maintain backwards compatibility. dlang/tools#292

Closed

dlang-bot added Review:Needs Rebase Review:Needs Work labels Jan 31, 2018

marler8997 mentioned this pull request Feb 2, 2018

[WIP] Investigate GraphQL for JSON introspection/filtering #7830

Closed

marler8997 mentioned this pull request Feb 4, 2018

Added -Xi to include new fields in JSON output #7838

Merged

wilzbach mentioned this pull request Feb 4, 2018

Issue 18368 - -X should print all static information on stdout if no files are given #7840

Closed

marler8997 mentioned this pull request Feb 15, 2018

Add more JSON #7894

Merged

wilzbach closed this Feb 15, 2018

Uh oh!

Implement -probe for showing supported features #7521

Implement -probe for showing supported features #7521

Uh oh!

Conversation

wilzbach commented Dec 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dlang-bot commented Dec 26, 2017

Bugzilla references

Uh oh!

wilzbach commented Dec 26, 2017

Uh oh!

ibuclaw Dec 26, 2017

Choose a reason for hiding this comment

Uh oh!

ibuclaw Dec 26, 2017

Choose a reason for hiding this comment

Uh oh!

JinShil Dec 27, 2017

Choose a reason for hiding this comment

Uh oh!

mathias-lang-sociomantic Dec 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mathias-lang-sociomantic Dec 29, 2017

Choose a reason for hiding this comment

Uh oh!

s-ludwig commented Dec 29, 2017

Uh oh!

ibuclaw commented Dec 29, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wilzbach commented Dec 29, 2017

Uh oh!

s-ludwig commented Jan 4, 2018

Uh oh!

wilzbach commented Jan 8, 2018

Uh oh!

timotheecour commented Jan 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marler8997 commented Jan 20, 2018

Uh oh!

timotheecour commented Jan 22, 2018

Uh oh!

wilzbach commented Jan 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CyberShadow commented Jan 22, 2018

Uh oh!

timotheecour commented Jan 22, 2018

Uh oh!

marler8997 commented Feb 4, 2018

Uh oh!

wilzbach commented Feb 15, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

wilzbach commented Dec 26, 2017 •

edited

Loading

mathias-lang-sociomantic Dec 29, 2017 •

edited

Loading

ibuclaw commented Dec 29, 2017 •

edited

Loading

timotheecour commented Jan 20, 2018 •

edited

Loading

wilzbach commented Jan 22, 2018 •

edited

Loading