fix Issue 519 - Invariant not called from autogenerated class/struct ctor/dtor #7536
Conversation
|
FYI: I am about to change the warning at dlang-bot, so that it isn't displayed for major issues anymore: dlang/dlang-bot#152 |
| } | ||
| } | ||
|
|
||
| version (none) // Controversial - see Bugzilla 519 |
There was a problem hiding this comment.
So are we going to do it, or not?
There was a problem hiding this comment.
Seems like this decision is the only thing holding this PR up. How about splitting it of into a separate PR?
ibuclaw
force-pushed
the
issue519
branch
2 times, most recently
from
3ab09ed to
f0fe660
Compare
|
Hmm, I think I've managed to turn 4995 into an error by moving the |
| e = el_combine(e, e1); | ||
| } | ||
|
|
||
| if (global.params.useInvariants && sle.sd.inv) |
There was a problem hiding this comment.
Inserting the invariant call here seems strange. Everywhere else it is controlled by addPostInvariant
|
What is stalling this PR, besides the rebase? @ibuclaw will you take this to the finish line? If not, I volunteer to adopt it. |
|
For anyone who is interested in this patch, I have created a rebase of this PR with the appropriate modifications #10022 |
8 participants
Rebase of #4136