-
-
Notifications
You must be signed in to change notification settings - Fork 668
Use a special D docker image for CircleCi #7579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
2e39327 to
c0f235d
Compare
6e85530 to
716fe2a
Compare
|
Hmm any Docker experts in the house? When this image is run on CircleCi I get weird permission errors - which don't happen locally: The image is built by the modifying the Docker base script (https://github.com/wilzbach/dlang-docker/blob/master/circleci/dlang.docker) - the custom patching is needed as AFAICT they only push their built images do DockerHub, not the base layer. (tested with image: dlang2/dmd-circleci@sha256:ee5c105f593b03a295c2a010a2e74561fa2aad19e9016fbe1bc86d6306f83edd) |
|
@wilzbach Regarding the permissions issue - I don't know if it is the same problem, but I had permissions issue when using the |
f083239 to
83033f9
Compare
ad6fa71 to
be84df5
Compare
|
Nice - this is finally failing: So we just need to fix the testsuite and then include this PR - or cherry-pick this PR into the PR that fixes the testsuite. (I will work a bit more on this as I would like the |
9d1404e to
fa046db
Compare
dd3b809 to
abc4663
Compare
abc4663 to
4dcac80
Compare
I think it's a different one, for some weird reason all I need to do to fix them is: Also I tried using CircleCi 2.0 workflows as this seems that's the only way to use different docker images. |
|
Cherry-picked this to #7420 -> closing. |


The Docker image is automatically built and updated: https://github.com/wilzbach/dlang-docker-circleci
I picked
ubuntu:17.04on purpose as currently the DMD and DRuntime testsuite doesn't work on a PIE-hardened system.Hence, the build should fail.
This will need something like #7420 or #7427