Fix Issue 18243 - selective import + overload = private visibility

[RazvanN7]

I fixed the issue by modifying the overloadApply method. The problem was that when resolving overloads the visibility attribute is not checked at all, so I had to add the scope as an optional parameter so that when an alias declaration is encountered (from imports or plain alias declarations) a check is made to make sure that the called function is indeed visible.

[dlang-bot]

Thanks for your pull request, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some tips to help speed things up:

• smaller, focused PRs are easier to review than big ones

• try not to mix up refactoring or style changes with bug fixes or feature enhancements

• provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Auto-close	Bugzilla	Description
✓	18243	selective import + overload = private visibility

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

[mathias-lang-sociomantic]

Selective imports creatingalias in the current scope is really an annoyance, and violates the principle of least surprise. I wish we could change that.

[RazvanN7]

That is a small project on its own which will propagate cascade changes throughout a large number of components.

[RazvanN7]

Although I agree that the current state is hackish and messy.

[mathias-lang-sociomantic]

Last time I checked with Walter, it was by design. Maybe that changed since. If you have any way to find out, it would be appreciated.

[wilzbach]

@RazvanN7 It looks like you need to fix a couple of projects. However, they are all in dlang-comunity or dlang-tour, so I have merge rights & thus I will be able to help you ;-)

[wilzbach]

@RazvanN7 making the PRs isn't too hard:

Fork and clone the respective repo

git checkout fix-imports-for-dmd-7766
dub test --compiler=/home/seb/dlang/dmd/generated/linux/release/64/dmd 
# fix the error & run until it passes
git add -u
git commit "Fix imports for dmd 7766"
pr_send

pr_send

[RazvanN7]

The jenkins failure is unrelated to this PR. Can we move forward with this? ping @andralex

[stefan-koch-sociomantic]

Is this in the changelog ?

[jacob-carlborg]

Is this in the changelog ?

Not in this PR.