Fix Issue 18367 - dmd should not segfault on -X with libraries, but no source files

[wilzbach]

I wish all segfaults would be that easy.

[dlang-bot]

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close	Bugzilla	Description
✓	18367	dmd should not segfault on -X with libraries, but no source files

[UplinkCoder]

@wilzbach indentation seems to suggest you missed braces.

[UplinkCoder]

LGTM

[wilzbach]

Argh this is failing on Windows :/

[timotheecour]

#7838 will supersede this behavior right? (but still good to submit in meantime)

[wilzbach]

I thought you don't want -X to emit JSON, but just -Xf=-?

[timotheecour]

ya, sorry ignore my comment

[marler8997]

PR #7838 addresses this (I had to since I have a test for it). I defaulted to writing to info.json, however, your approach of asserting an error works as well. Let me know what you want to do.

[wilzbach]

I think producing an error is saner then writing to a default info.json file. This would just need extra documentation and the case isn't very popular anyways.

[marler8997]

Ok I changed my PR to issue an error in this case:

Error: cannot determine JSON filename, use -Xf=<file> or provide a source file

[marler8997]

this whole file is bash wizadry...I can see one is strong with the bash

[marler8997]

I copied this test to my PR, and added another case to it

[timotheecour]

I defaulted to writing to info.json, however, your approach of asserting an error works as well. Let me know what you want to do.

indeed, IMO as a general rule it's always better to be explicit (let user choose file name or give error); it reduces bugs (eg what if a user already had an info.json and didn't intend it to be deleted)

[wilzbach]

Closing this in favor of #7838 then. Thanks @marler8997 !