-
-
Notifications
You must be signed in to change notification settings - Fork 672
dmd part of fix for 18559 #7995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
|
Druntime & phobos parts to follow. |
druntime part dlang/dmd#7995
|
Dumb question: is there a way to check that this emits the expected machine code? Or we simply don't have the facilities for that in place? |
We do, it's just not very well-known and at the moment the it contains quite a lot of duplication: https://github.com/dlang/dmd/blob/master/test/runnable/test_cdvecfill.d At some point this should probably be factored out into one small library and one update script ... |
|
What's the status of this? What still needs to be done in order to be considered? |
|
I'd prefer #8002 to go instead of this but it fails for 32-bit, idk why, I won't have time to work on this until dconf. In the meantime this should suffice for the druntime and phobos parts assuming I have the mangling correct, but should probably be tested in conjunction with the associated druntime and phobos PRs to make sure. |
|
Haha. Go with this one, unless you want to figure out why the other one fails for 32-bit. I plan to get the other one working at dconf. |
|
Can we get this one pulled? #8071 |
|
Possibly a regression introduced by this PR. https://issues.dlang.org/show_bug.cgi?id=24040 There are float and double overloads for these core.math intrinsics, but they all still map to x87 instructions, and get treated as if the precision is 80-bit. |
Add a bunch of overloads for intrinsics for in
core.math.