Skip to content

Conversation

@marler8997
Copy link
Contributor

This PR is in preparation for other functionality (such as skipping unittests in imported modules). It modifies the code to determine if a module is a "root module" (a module being compiled to object code) as soon as the module name has been determined which is just after the module declaration has been parsed.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @marler8997! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8151"

@marler8997 marler8997 force-pushed the moduleHook branch 2 times, most recently from d4127a9 to 0e517bc Compare April 7, 2018 18:15
@marler8997
Copy link
Contributor Author

Ping

@marler8997 marler8997 closed this May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants