Skip to content

[trivial] Combine format strings in getParamError #8283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 1 commit into from
May 23, 2018
Merged

[trivial] Combine format strings in getParamError #8283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/dmd/mtype.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4790,10 +4790,9 @@ extern (C++) final class TypeFunction : TypeNext
OutBuffer buf;
// only mention rvalue if it's relevant
const rv = !arg.isLvalue() && par.storageClass & (STC.ref_ | STC.out_);
const char* fmt = rv ?
"cannot pass rvalue argument `%s` of type `%s` to parameter `%s`" :
"cannot pass argument `%s` of type `%s` to parameter `%s`";
buf.printf(fmt, arg.toChars(), at, parameterToChars(par, this, qual));
buf.printf("cannot pass %sargument `%s` of type `%s` to parameter `%s`",
rv ? "rvalue ".ptr : "".ptr, arg.toChars(), at,
parameterToChars(par, this, qual));
return buf.extractString();
}

Expand Down