-
-
Notifications
You must be signed in to change notification settings - Fork 667
convert gflow.c to D #8424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert gflow.c to D #8424
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8424" |
5dd7b68 to
ca0bc1d
Compare
|
@CyberShadow looks like a problem with CyberShadow/DAutoTest : |
|
|
||
| extern "C" | ||
| { | ||
| void fillInDNunambig(vec_t v, elem *e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this change unrelated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I set it to C to avoid name mangling issues with vec_t which is our annoying friend size_t.
|
|
||
| void vec_setclear(size_t b, vec_t vs, vec_t vc) { vec_setbit(b, vs); vec_clearbit(b, vc); } | ||
|
|
||
| bool Eunambig(elem* e) { return OTassign(e.Eoper) && e.EV.E1.Eoper == OPvar; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already defined in gdag.d - why not import it (or move it to a common bit)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the 'header' files are a mess at the moment, and I decided to defer dealing with that. My goal is to do the least disruptive thing to get the files converted to D. Then, start doing refactoring and removing technical debt.
convert gflow.c to D
No description provided.